Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-4632: Mark backup codes as "Least secure" to discourage use #5148

Merged
merged 1 commit into from Jun 15, 2021

Conversation

solipet
Copy link
Contributor

@solipet solipet commented Jun 14, 2021

As a user, when presented with the choice of MFA options, I want to know that Backup Codes are considered the least secure option, so that if I'm given the choice between Phone and Backup Codes, I'm not motivated to choose Backup Codes out of convenience absent any indication they're considered relatively less secure.

This is an action item out of the analysis of LG-3791, where it was discovered that we saw an uptick in selections of "Backup Code" as an MFA option after we had changed the label of "Phone" to be described as equally "Less Secure". Since we consider Phone to be relatively more secure than Backup Codes, we should avoid presenting them as equally secure.

To do this, we changed the label of Backup Codes to "Least Secure". We also refreshed the translation of all labels, with the resulting screens shown below:

en es fr
mfa-options-en mfa-options-es mfa-options-fr

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

less_secure_label: Less secure
more_secure_label: More Secure
most_secure_label: Most Secure
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why i18n-tasks unused doesn't flag this 🤔 It doesn't appear to match any of our currently ignored patterns. I don't think it's much of a problem; just wouldn't want to be surprised by spontaneous build failures in the future 😅

Copy link
Contributor

@anniehirshman-gsa anniehirshman-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks!

@solipet solipet merged commit afc6d75 into main Jun 15, 2021
@solipet solipet deleted the dprice-lg-4632-least-secure-mfa branch June 15, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants