Remove bin/yarn to avoid running "yarn install" unnecessarily #5453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
approved these changes
Sep 28, 2021
There was a problem hiding this comment.
Interesting, looks like it's coming from Sprockets:
https://github.com/rails/rails/blob/6-1-stable/railties/lib/rails/tasks/yarn.rake#L27-L30
Alternatively, we could remove the yarn install from deploy/build and enhance bin/yarn to handle offline? Not much difference anyways.
I notice Rails also passes --no-progress. Makes me recall how NPM's progress bar had a noticeable performance impact a long while ago (npm/npm#11283), though I dunno if it actually applies here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to
yarn installin offline mode (#5419), I noticed we were still running yarn installs when compiling assets. This webpacker issue suggests deletingbin/yarn, which was generated and added as part of the Rails 6.1 upgrade.Removing this file doesn't appear to break any of our setup scripts, tests, or build processes.