Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Changelog on Pull Requests (LG-5631) #5836

Merged
merged 14 commits into from Jan 25, 2022

Conversation

mitchellhenke
Copy link
Contributor

@mitchellhenke mitchellhenke commented Jan 19, 2022

This PR implements a check for pull requests against this repo that requires a line be added to CHANGELOG.md in the form of:

+- CATEGORY: CHANGE_DESCRIPTION (#PULL_REQUEST_NUMBER)

+-  Maintenance: Update Node.js to v14 (#5786)

It can be skipped with a commit message in the PR that contains [skip changelog].

CHANGELOG.md Outdated Show resolved Hide resolved
@mitchellhenke mitchellhenke changed the title [WIP] Require Changelog on Pull Requests (LG-5631) Require Changelog on Pull Requests (LG-5631) Jan 20, 2022
@mitchellhenke mitchellhenke marked this pull request as ready for review January 20, 2022 16:24
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a try 👍

scripts/changelog-check Outdated Show resolved Hide resolved
scripts/changelog-check Outdated Show resolved Hide resolved
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/changelogs branch 10 times, most recently from 11eba74 to 2dd9159 Compare January 25, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants