New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Changelog on Pull Requests (LG-5631) #5836
Merged
Merged
+199
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellhenke
force-pushed
the
mitchellhenke/changelogs
branch
5 times, most recently
from
January 19, 2022 18:01
23be837
to
2da64d6
Compare
mitchellhenke
force-pushed
the
mitchellhenke/changelogs
branch
from
January 19, 2022 22:58
819b890
to
fdd4439
Compare
mitchellhenke
changed the title
[WIP] Require Changelog on Pull Requests (LG-5631)
Require Changelog on Pull Requests (LG-5631)
Jan 20, 2022
mitchellhenke
force-pushed
the
mitchellhenke/changelogs
branch
from
January 21, 2022 17:02
7407a65
to
4b0484e
Compare
aduth
approved these changes
Jan 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give it a try 👍
mitchellhenke
force-pushed
the
mitchellhenke/changelogs
branch
10 times, most recently
from
January 25, 2022 15:02
11eba74
to
2dd9159
Compare
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
mitchellhenke
force-pushed
the
mitchellhenke/changelogs
branch
from
January 25, 2022 15:19
2dd9159
to
ac56a36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a check for pull requests against this repo that requires a line be added to CHANGELOG.md in the form of:
+- CATEGORY: CHANGE_DESCRIPTION (#PULL_REQUEST_NUMBER)
+- Maintenance: Update Node.js to v14 (#5786)
It can be skipped with a commit message in the PR that contains
[skip changelog]
.