-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document analytics event number 9 #6186
Conversation
8f8afb5
to
d326fc5
Compare
app/services/analytics_events.rb
Outdated
# @identity.idp.event_name Idv address submitted | ||
# User submitted an idv address | ||
def idv_address_submitted( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you document the params? Running make lint_analytics_events
will help highlight these
app/services/analytics_events.rb:366 idv_address_submitted success (undocumented)
app/services/analytics_events.rb:366 idv_address_submitted errors (undocumented)
app/services/analytics_events.rb:366 idv_address_submitted address_edited (undocumented)
app/services/analytics_events.rb:366 idv_address_submitted error_details (undocumented)
make: *** [lint_analytics_events] Error 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, added now.
d326fc5
to
50a5f65
Compare
changelog: Improvements, Analytics, Added analytic events (LG-5927)
50a5f65
to
7c0a58b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
IDV_BASIC_INFO_VISIT = 'IdV: basic info visited' | ||
IDV_BASIC_INFO_SUBMITTED_FORM = 'IdV: basic info form submitted' | ||
IDV_BASIC_INFO_SUBMITTED_VENDOR = 'IdV: basic info vendor submitted' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just confirmed that these 3 events were removed in #3682 and seem to have been unused at that time, so I think there's no need to link these to current events, they're super out of date
This documents analytic events related to this ticket: https://cm-jira.usa.gov/browse/LG-5927