Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use URL-safe base64 encoding of SHA256 digest in examples #6210

Merged
merged 3 commits into from
Apr 15, 2022

Conversation

zachmargolis
Copy link
Contributor

Why: adheres to OIDC spec better

Fixes #5991

**Why**: adheres to OIDC spec better

Fixes #5991
changelog: Internal, Encoding, Use URL-safe encoding of SHA256 digests to better match OIDC spec
Copy link
Contributor

@stevegsa stevegsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@zachmargolis zachmargolis merged commit e03a691 into main Apr 15, 2022
@zachmargolis zachmargolis deleted the margolis-urlsafe branch April 15, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OIDC tests use incorrect PKCE code_challenge computation
3 participants