-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-6159: Add icons for personal key buttons #6212
Conversation
def local_crossorigin_sources? | ||
Rails.env.development? && ENV['WEBPACK_PORT'].present? | ||
end | ||
|
||
def javascript_assets_tag(*names) | ||
assets = AssetSources.get_assets(*names) | ||
if assets.present? | ||
asset_map = assets.index_with { |path| asset_path(path) } | ||
asset_map = assets.index_with { |path| asset_path(path, host: asset_host(path)) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For extra context on why we have to do this, see #5895 and related discussions / resources.
Testing this in my personal environment (with asset host), I'm not seeing the icons 🤔 Will have to investigate what's going on... |
This turned out to be a separate issue, addressed in #6214. |
For consistency with ButtonComponent ViewComponent
changelog: Upcoming Features, Identity Verification, Add personal key step screen
Not necessary, since the condition considers the config value, not env
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
663905f
to
dd0f72b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following testing instructions icons appear as expected 👍
| 'zoom_in' | ||
| 'zoom_out' | ||
| 'zoom_out_map'; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be nice to have this list live in another file, just for the sake of readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, that's a good thought. I guess the question is... where to put it?
One consideration is that I'm hoping to remove the "Custom Icon" implementation mixed in here (createIconComponent
), since the one icon being used is available through this new icon set (photo_camera
), which will hopefully make the file a bit smaller overall.
I think I'll plan to merge this as-is, but follow-up with that work, and if we decide there's a better place for the icon list type, I can plan to include it there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
Why: For feature parity with the existing personal key screen experience.
Testing Instructions:
idv_api_enabled: "true"
in localconfig/application.yml
Screenshots: