Enhance FormSteps to manage history using path fragment #6213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
commented
Apr 15, 2022
aduth
commented
Apr 15, 2022
aduth
commented
Apr 15, 2022
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
aduth
force-pushed
the
aduth-use-history-path
branch
from
eb0f400
to
75b9080
Compare
aduth
commented
Apr 18, 2022
Should be responsibility of consumer to deal with lingering path fragment upon completion if necessary changelog: Upcoming Features, Identity Verification, Add client-side application path routing
**Why**: Because it will be necessary to reliably create step URLs #6213 (comment)
We're not using a query parameter format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: So that I can navigate back and forth in the new IdV v2 application, and my location is maintained accurately in the address bar path.
In the original document capture implementation, we included history management as part of the "steps" implemented there. That implementation only allowed for querystring-based hash fragments (e.g.
/document_capture#step=selfie).Because we want the React application to manage incoming routed URLs from Rails, and because hash fragment routing is unsightly, this pull request seeks to expand this base support to allow for path-based history management.
Testing Instructions:
idv_api_enabled: "true"in localconfig/application.yml/verify/v2/personal_key_confirm/verify/v2/)Video:
Screen.Recording.2022-04-15.at.4.10.22.PM.mov
Draft only because I wrapped this up rather quickly at the end of the day and haven't had a chance to give it a thorough look-over, but functionally it seems to work quite fine.