Fix broken link #899
Fix broken link #899
Conversation
**Why**: `idv_url` is no longer a route name
jessieay
force-pushed
the
jy-fix-broken-link
branch
from
52edba4
to
df0cad6
Compare
There was a problem hiding this comment.
@monfresh is removing that Back link in #894 -- and based on the reasoning about user experience, I think we may want to go that way instead? WDYT?
Motivation from the other PR:
The "Back" link on the /verify/activated page that points to the
/verify endpoint doesn't make sense because it will send right back
to the /verify/activated page. I removed the link because the only
place where it makes sense to link back to is the profile page, which
is already accessible via the "My account" link or the login.gov logo.
| @@ -3,4 +3,4 @@ | |||
| h1.h3.my0 = t('idv.titles.activated') | |||
| p.mt-tiny.mb0 = t('idv.messages.activated_html', | |||
| link: link_to(t('idv.messages.activated_link'), contact_path)) | |||
| = link_to 'Back', idv_url | |||
| = link_to t('forms.buttons.back'), verify_path | |||
There was a problem hiding this comment.
looks like @monfresh is getting rid of this exact same link in https://github.com/18F/identity-idp/pull/894/files ... there will be a merge conflict
There was a problem hiding this comment.
I am fine with either direction.
|
Closing in favor of #894 |
Why:
idv_urlis no longer a route nameCloses #898