Certificate Chain Service #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmargolis
requested review from
jmhooper,
mitchellhenke,
achapm and
stevegsa
zachmargolis
force-pushed
the
margolis-chain-certificate-service
branch
from
3841c29
to
376429e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating and committing @achapm's WIP branch because we use it in our handbook
My changes are mainly in 97d8723, to update the class to take in a
Certificateinstance instead of hardcoding a key ID and URLFuture ideas:
key_ids in the certificate storeThere are no tests...please let me know if folks feel strongly and I can spend some more time and webmock some stuff togetherI added tests!