Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LG-3770 Upgrade to Rails 6 #173

Merged
merged 1 commit into from
Nov 20, 2020
Merged

LG-3770 Upgrade to Rails 6 #173

merged 1 commit into from
Nov 20, 2020

Conversation

stevegsa
Copy link
Contributor

No description provided.

@stevegsa stevegsa changed the title Upgrade to Rails 6 LG-3770 Upgrade to Rails 6 Nov 20, 2020
@stevegsa stevegsa marked this pull request as ready for review November 20, 2020 04:00
zachmargolis
zachmargolis approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's make sure to test in a lower env

@stevegsa stevegsa merged commit 854188c into master Nov 20, 2020
@stevegsa stevegsa deleted the stevegsa-pki-rails-6 branch November 20, 2020 17:05
jmhooper added a commit that referenced this pull request Dec 13, 2020
@jmhooper
Revert "Upgrade to Rails 6 (#173)"
8fcd685 
This reverts commit 854188c.
jmhooper added a commit that referenced this pull request Dec 13, 2020
@jmhooper
Revert "Upgrade to Rails 6 (#173)"
d63e385 
This reverts commit 854188c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmargolis zachmargolis zachmargolis approved these changes

Assignees
No one assigned
Labels
status - ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevegsa @zachmargolis