Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable HTTP requests to CA issuer (LG-4037) #197

Merged

Conversation

mitchellhenke
Copy link
Contributor

@mitchellhenke mitchellhenke commented Jan 19, 2021

Follow up to #193

All of the added hosts come from the stored certificates with the exception of sspweb.managed.entrust.com, which is what my PIV has.

We are logging when we don't have a cert stored and can't verify it through CA Issuers, and could add those here as well.

@mitchellhenke mitchellhenke marked this pull request as ready for review January 19, 2021 18:10
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

spec/services/issuing_ca_service_spec.rb Outdated Show resolved Hide resolved
spec/services/issuing_ca_service_spec.rb Show resolved Hide resolved
app/services/issuing_ca_service.rb Outdated Show resolved Hide resolved
@mitchellhenke mitchellhenke merged commit 4d5f357 into master Jan 28, 2021
@mitchellhenke mitchellhenke deleted the mitchellhenke/enable-http-requests-to-issuer-lg-4037 branch January 28, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants