Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve expiring cert task language to avoid misleading replacement window #418

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented Jan 11, 2024

🛠 Summary of changes

Updates messaging displayed as the output of the rake print_expiring task to improve clarity.

The intent of the message is to explain the window of time which was checked for an expiring certificate.

The concern is that the message may mislead a reader into thinking that the listed certificates can be replaced by that time, even if the actual expiration is sooner.

@aduth aduth changed the title Improve expiring cert task language to avoid misleading replacement workflow Improve expiring cert task language to avoid misleading replacement window Jan 11, 2024
@aduth
Copy link
Member Author

aduth commented Jan 11, 2024

The failing build appears to be related to the known expiring certificate, tracked in LG-12045.

Conveniently, it also serves as nice validation of these changes 😄

Found certs expiring between now and 2024-02-10 13:52:58 UTC
- Expiration: 2024-01-21 14:38:10 UTC
  Subject: /C=US/O=ORC PKI/CN=ORC SSP 4
  Issuer: /C=US/O=U.S. Government/OU=FPKI/CN=Federal Common Policy CA G2
  Key ID: 14:0B:99:1F:98:1F:64:8C:6F:C3:FF:7A:D5:FF:F5:F8:4E:49:9C:21

@aduth
Copy link
Member Author

aduth commented Jan 11, 2024

Merging bypassing failing build, based on explanation at #418 (comment).

@aduth aduth merged commit 13df810 into main Jan 11, 2024
1 check failed
@aduth aduth deleted the aduth-rake-task-deadline branch January 11, 2024 15:31
@mitchellhenke mitchellhenke restored the aduth-rake-task-deadline branch June 13, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants