Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DOD ID CA 70-73 certs #435

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Add DOD ID CA 70-73 certs #435

merged 4 commits into from
Mar 12, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented Mar 12, 2024

Related Slack discussion: https://gsa-tts.slack.com/archives/C20J64X6V/p1710174734532059

These are copied out of ficam_bundle.pem, corresponding to issuers from user certificates from support escalation and verified locally.

@aduth aduth requested review from amirbey, mitchellhenke and a team March 12, 2024 14:53
@aduth
Copy link
Member Author

aduth commented Mar 12, 2024

The build is failing due to a certificate expiring on April 9th. I'm inclined to merge despite the failure, as the alternative is to remove the expiring certificate, but April 9th is quite far off and a replacement may become available between now and then.

@aduth aduth merged commit 8a0072d into main Mar 12, 2024
1 check failed
@aduth aduth deleted the aduth-dod-certs branch March 12, 2024 16:03
@zachmargolis
Copy link
Contributor

The build is failing due to a certificate expiring on April 9th. I'm inclined to merge despite the failure, as the alternative is to remove the expiring certificate, but April 9th is quite far off and a replacement may become available between now and then.

I feel like it's time to rethink failing builds on expired certs, it's definitely something we want to be aware of but I'm not sure it's a "stop the presses!!!!" moment like our CI makes it out to be

@aduth
Copy link
Member Author

aduth commented Mar 12, 2024

I feel like it's time to rethink failing builds on expired certs, it's definitely something we want to be aware of but I'm not sure it's a "stop the presses!!!!" moment like our CI makes it out to be

Yeah, I agree. I also think it's also not very effective as currently implemented, since it relies on someone opening a pull request to trigger the failure. No pull requests in a month? We may not be notified at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants