Merge pull request #518 from 18F/ad-hotfix-veil-winning-bidder-from-api

omit winning bid in api
18F · May 4, 2016 · f2aaae7 · f2aaae7
2 parents c989048 + 9a043fa
commit f2aaae7
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 34 deletions.
diff --git a/app/serializers/auction_serializer.rb b/app/serializers/auction_serializer.rb
@@ -11,8 +11,7 @@ class AuctionSerializer < ActiveModel::Serializer
     :start_price,
     :summary,
     :title,
-    :updated_at,
-    :winning_bid
+    :updated_at
   )
 
   def bids
@@ -35,14 +34,4 @@ def end_datetime
   def start_datetime
     object.start_datetime.iso8601
   end
-
-  def winning_bid
-    WinningBidSerializer.new(find_winning_bid)
-  end
-
-  private
-
-  def find_winning_bid
-    RulesFactory.new(object).create.winning_bid
-  end
 end
diff --git a/spec/support/api/schemas/auction.json b/spec/support/api/schemas/auction.json
@@ -48,17 +48,6 @@
             "type": "string",
             "minLength": 1
           },
-          "winning_bid": {
-            "type": "object",
-            "properties": {
-              "amount": {
-                "type": ["number", "null"]
-              },
-              "bidder_id": {
-                "type": ["number", "null"]
-              }
-            }
-          },
           "bids": {
             "type": "array",
             "uniqueItems": true,

diff --git a/spec/support/api/schemas/auctions.json b/spec/support/api/schemas/auctions.json
@@ -64,17 +64,6 @@
             "type": "string",
             "minLength": 1
           },
-          "winning_bid": {
-            "type": "object",
-            "properties": {
-              "amount": {
-                "type": ["number", "null"]
-              },
-              "bidder_id": {
-                "type": ["number", "null"]
-              }
-            }
-          },
           "bids": {
             "type": "array",
             "uniqueItems": true,