This repository has been archived by the owner on Jul 30, 2019. It is now read-only.
Deploy #2 12/30 #180
Merged
Deploy #2 12/30 #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not include any tests yet. Want to firm up that this is what we want first
Even if the logged in user is not the winner of the auction, the check will crash if there is no logged in user. The check could also be fixed to return false if nobody is logged in, but will just make this change for now instead since I don't want to modify that method yet.
This does not include any tests yet. Want to firm up that this is what we want first
Even if the logged in user is not the winner of the auction, the check will crash if there is no logged in user. The check could also be fixed to return false if nobody is logged in, but will just make this change for now instead since I don't want to modify that method yet.
Added failing spec for closed, bidless auction.
Also, there were no tests for user_is_winning_bidder? method. Ooops.
The idea is to use the header to indicate the status of auctions
Indicate winner
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auction improvements