This repository has been archived by the owner on Nov 7, 2018. It is now read-only.
add back location field type for location.lat & location.lon field filter #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address #227, where
location.latandlocation.lonvalues are not being returned in a fields search because they are explicitly being excluded from the field_types and the error checker kicks out the request.The above issue mentions excluding
latandlonwas done on a special case for the location field (necessary for geo search by distance?), however, I don't see any issue that keeping lat/lon has an affect on a distance search.Additionally, in order to store and index the
latandlonso as to return them in a fields filter query, we need to set thelat_lonmapping option for thelocationfield's geo_point type. Thelat_lonoption will then index these values as fields.Also needed to update a couple tests that we're expecting lat/lon to not be able to return results as well as added a test for a field filter query to return coordinates.