This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Adding aggregate links to itemized tables #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 3, 2015 18:28
Including a new helper functioning for setting min and max dates from a cycle year
|
Oh, I should add: for a few of the links it seems we need to implement corresponding filters on the browse view. I think the ones missing are:
The last two confuse me because I thought we had those working, but maybe I'm doing something wrong. I know that #406 fixes these filters on the frontend. |
|
We will need to filter out non-individual line-items too or the not reported total will not match. That depends on making line number a parameter #18F/openFEC/1102 |
|
Thanks@LindsayYoung . Just captured in #412 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw an opportunity to help with one of the dev tasks ( #376 ), so I went ahead and did it. This adds links to the amounts in the Receipts and Disbursements tab tables to the itemized transactions that make up the total. So when you click the Facebook total in this table:
It shows the transactions that make up that total:
I tried to code this up in a smart, reusable way, but please let me know if there's anything I should do to tighten it up (I imagine there is).