Skip to content
This repository has been archived by the owner on Aug 27, 2019. It is now read-only.

Commit

Permalink
Rule changes based on current guide
Browse files Browse the repository at this point in the history
All the following rules I've changed are based on what I found
in the guide, that were probably being mis-represented in the scss
-lint config.

- import-path-filename-extension: Webpack often needs file extensions to
function correctly, so I think this rule should be turned off.
- declaration-block-max-declarations: we don't actually specify anywhere
in the guide that you cannot have more then 10 declarations. I think
this was mistakenly brought in from another config.
- selector-pseudo-element-colon-notation: saying two colons isn't
specified in the guide so I took it out. Is it required at all?
- value-list-comma-newline-after: this was changed to what I think we
wanted it to be.

Ran the tests and they passed.
  • Loading branch information
Marco Segreto committed Jun 8, 2016
1 parent 18e486d commit 750d841
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions src/stylelint-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@ var configs = {
"plugins": [
"./plugins/no-at-debug",
"./plugins/import-path-leading-underscore",
"./plugins/import-path-filename-extension",
"./plugins/else-placement",
"./plugins/declaration-block-max-declarations",
"./plugins/name-format",
"./plugins/url-format"
],
Expand Down Expand Up @@ -72,9 +70,7 @@ var configs = {
},
"plugin/no-at-debug": true,
"plugin/import-path-leading-underscore": false,
"plugin/import-path-filename-extension": false,
"plugin/else-placement": 'same-line',
"plugin/declaration-block-max-declarations": 10,
"plugin/name-format": {
'allow-leading-underscore': false,
'convention': 'hyphenated-lowercase'
Expand All @@ -95,14 +91,14 @@ var configs = {
"selector-pseudo-class-case": "lower",
"selector-pseudo-class-parentheses-space-inside": "never",
"selector-pseudo-element-case": "lower",
"selector-pseudo-element-colon-notation": "double",
"selector-pseudo-element-colon-notation": false,
"selector-pseudo-element-no-unknown": true,
"selector-type-case": "lower",
"string-no-newline": true,
"string-quotes": "single",
"unit-case": "lower",
"unit-no-unknown": true,
"value-list-comma-newline-after": "never-multi-line",
"value-list-comma-newline-after": "always-multi-line",
"value-list-comma-space-after": "always-single-line",
"value-list-comma-space-before": "never"
}
Expand Down

0 comments on commit 750d841

Please sign in to comment.