Feature: TS declaration support #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamikazebr
changed the title
kamikazebr
commented
Dec 18, 2021
kamikazebr
commented
Dec 18, 2021
| @@ -98,9 +105,9 @@ | |||
| "react-blockies": "^1.4.0", | |||
| "react-display-name": "^0.2.3", | |||
| "react-onclickout": "^2.0.8", | |||
| "react-spring": "^7.2.11", | |||
| "react-spring": "7.2.10", | |||
There was a problem hiding this comment.
The version 7.2.11 not exist anymore, so was neeed rollback to resolve some conflict on types definition.
kamikazebr
commented
Dec 18, 2021
| "recursive-copy": "^2.0.9", | ||
| "use-inside": "^0.2.0" | ||
| "use-inside": "https://github.com/aragon/use-inside#16f321e499d8f89e9b0fb0999e2d21db2b119bbf" |
There was a problem hiding this comment.
On bundle api-extractor cannot found definition of use-inside on the last version published on npm, but on currenty master (referenced by commit for safety install), have the TS definitions updated
5 tasks
0xGabi
approved these changes
Dec 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It include automation to autogenerated typescript definitions and bundled on one single file to distribute together with the package.
Running
yarn buildwill generate the type definition ondist/types/index.d.ts