Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update react-spring version #32

Merged
merged 10 commits into from
Apr 13, 2022
Merged

update react-spring version #32

merged 10 commits into from
Apr 13, 2022

Conversation

reznord
Copy link

@reznord reznord commented Mar 25, 2022 •
edited
Loading

Summary

This PR keep track of the update of the react-spring library to the latest version of the library.

I am opening a separate pull-request just for updating the react-spring library because the changes are a bit complex and might get mixed up in the update progress. Also it will be easier to review smaller chunks.

Closes #31

Progress:

I copied all the components that are listed in the devbox here as check-list to keep track of the progress for the update.

  • Accordion
  • AddressField
  • AppBadge
  • AppBarTabs
  • AppView
  • AutoComplete
  • Bar
  • Button
  • Card
  • Checkbox
  • CircleGraph
  • Colors
  • ContextMenu
  • DataView
  • DateRangePicker
  • Details
  • DiscButton
  • Distribution
  • DropDown
  • EmptyStateCard
  • EthIdenticon
  • FloatIndicator
  • Help
  • Icons
  • IdentityBadge
  • Info
  • Input
  • Layout
  • LineChart
  • Link
  • LinkedSliders
  • LoadingRing
  • Markdown
  • Modal
  • NavigationBar
  • Pagination
  • Popover
  • ProgressBar
  • Radio
  • RadioList
  • Scratchpad
  • SidePanel
  • Switch
  • SyncIndicator
  • Tabs
  • Tag
  • TextCopy
  • TextStyles
  • Theme
  • Timer
  • TokenBadge
  • TransactionBadge
  • TransactionProgress
  • Viewport
  • Wrappers
  • Everything

@reznord reznord self-assigned this Mar 25, 2022
kamikazebr
kamikazebr approved these changes Mar 27, 2022
View reviewed changes
Copy link
Member

@kamikazebr kamikazebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Tested all components visualy, looks working properly the animations.

Note: Maybe remove that comment across multiples files // import { Transition, animated } from 'react-spring/renderprops'

@reznord
Copy link
Author

reznord commented Apr 13, 2022

LGTM!

Tested all components visualy, looks working properly the animations.

Note: Maybe remove that comment across multiples files // import { Transition, animated } from 'react-spring/renderprops'

done :)

@reznord reznord merged commit 7f020e0 into feat/gh-785 Apr 13, 2022
@reznord reznord deleted the 31-update-react-spring-version branch April 13, 2022 12:00
@reznord reznord mentioned this pull request Apr 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamikazebr kamikazebr kamikazebr approved these changes

@0xGabi 0xGabi Awaiting requested review from 0xGabi

@rperez89 rperez89 Awaiting requested review from rperez89

@tmoutinho tmoutinho Awaiting requested review from tmoutinho

Assignees

@reznord reznord

Labels
None yet
Projects
No open projects
Gardens 🌻
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reznord @kamikazebr