Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit changes. #103

Merged
merged 5 commits into from
Dec 20, 2019
Merged

Audit changes. #103

merged 5 commits into from
Dec 20, 2019

Conversation

willjgriff
Copy link
Member

Added uniqueness check for acceptedTokens in init function. Added/fixed tests.

fabriziovigevani
fabriziovigevani reviewed Dec 17, 2019
View reviewed changes
Copy link
Member

@fabriziovigevani fabriziovigevani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good man!

Could we also update the token list order on the Template?
Specifically:

token-request-app/contracts/examples/Template.sol

Line 142 in 2fe4aff

tokenList[0] = address(testToken);

token-request-app/contracts/examples/Template.sol

Line 143 in 2fe4aff

tokenList[1] = address(0);

@willjgriff willjgriff merged commit ddf2a3e into master Dec 20, 2019
@willjgriff willjgriff deleted the audit-changes branch December 20, 2019 11:39
@fabriziovigevani fabriziovigevani mentioned this pull request Dec 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziovigevani fabriziovigevani fabriziovigevani approved these changes

@rperez89 rperez89 Awaiting requested review from rperez89

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willjgriff @fabriziovigevani