Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README updates #28

Merged
merged 1 commit into from
Aug 5, 2021
Merged

README updates #28

merged 1 commit into from
Aug 5, 2021

Conversation

benwestrate
Copy link
Contributor

Fixes

  • The ItemBuilder example needed to have the new keyword.
  • The logging section needs and updated example to have DEBUG=opconnect:* otherwise debug does not log the requests or the builder logs

@benwestrate
ReadMe Docs fixes
c3bdcdc 
Fixes
- The ItemBuilder example needed to have the `new` keyword. 
- The logging section needs and updated example to have `DEBUG=opconnect:*` otherwise debug does not log the requests or the builder logs
@verkaufer verkaufer self-requested a review August 5, 2021 23:48
verkaufer
verkaufer approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@verkaufer verkaufer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching these!

@verkaufer verkaufer merged commit 636ce59 into 1Password:main Aug 5, 2021
@edif2008 edif2008 mentioned this pull request Sep 9, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verkaufer verkaufer verkaufer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benwestrate @verkaufer