Remove 'setVault' from ItemBuilder #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `createItem` function has the wrong signature in the README example.
Remove `setVault` from ItemBuilder to enable creating the item in multiple vaults and eliminate confusion of the `itemCreate` signature. Also, the builder no longer enforces to have the vault set.
Codecov Report
@@ Coverage Diff @@
## main #31 +/- ##
==========================================
- Coverage 96.85% 96.80% -0.06%
==========================================
Files 19 19
Lines 445 438 -7
Branches 57 55 -2
==========================================
- Hits 431 424 -7
Misses 14 14
Continue to review full report at Codecov.
|
verkaufer
suggested changes
Aug 10, 2021
verkaufer
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing
setVaultfrom ItemBuilder, the user will no longer be confused about whether the vault UUID should be provided when callingcreateItem. Also, this enables the user to create the same item in multiple vaults.