Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore instances of ${{ ... }} when creating a CodeLens suggestion #175

Merged
merged 2 commits into from
May 21, 2024

Conversation

dethancosta
Copy link
Contributor

A filter is applied when creating a CodeLens, ignoring any field value that has a template format (i.e., ${{ ... }}).

resolves #91

@techcraver
Copy link

Thanks for the submission!

@techcraver
Copy link

Thanks for your contribution! We appreciate it.
Please know that we're a small team and we'll reply to your PR as soon as we can.

@jodyheavener
Copy link
Member

Finally got around to reviewing this - it looks great. Will include in the next release. Thank you!

@jodyheavener jodyheavener merged commit 5ed6d6a into 1Password:main May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't offer to save GitHub Secret format
3 participants