Add ability to use multiple accounts with the same server url #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dethancosta
changed the title
|
Any chance this could get merged soon? It would be tremendously helpful! |
|
Pleeeeeease!! |
|
Is it possible to take a look at this pr? Is there something were missing here? It looks like the extension may be currently unusable for users with different accs on the same server (e.g., my.1password.com). Many thanks! |
* origin/main:
Upgrade @1password/eslint-config and @typescript-eslint/eslint-plugin, add eslint, remove eslint-plugin-jsdoc eslint-plugin-prettier eslint-plugin-sonarjs eslint-plugin-unicorn
Bump ts-jest
Bump lint-staged
Update esbuild esbuild-register husky license-checker-rseidelsohn lint-staged
Bump Typescript to 5.4.5
Update prettier deps
Update Test and Publish workflow Node version
Partially update jest.config.js to support Winddows
Update build and eslint commands to support running on Windows
Bump to node 18.18.0
Ignore instances of ${{ ... }} when creating a CodeLens suggestion
|
Sorry for the holdup, folks. Have tried this out and it all works great. 🚀 Will include in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the account flag used from the account URL to the account ID, allowing the user to switch between accounts both having a URL with, e.g., my.1password.com.
To test, simply open the command palette, choose either
1password: choose accountor1password: choose vault, choose the account/vault, and you should get the expected behaviour with no error message.resolves #88