-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECS Terraform Fargate Deployment #127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll go with the moto: "Let's try to keep the example minimal"
You are assuming people manage dns with route 53, i'd remove any route 53 requirement and just says "make sure you have a CNAME or A record pointing to the ECS load balancer"
(which is in the prerequisite.md at root IIRC)
From what I read you are not using Let's encrypt stuff but AWS signing, that means that the client needs to have was certificates and ACM set up ? I know this is tricky though to use lets encrypt instead. It might also be ok.
I was trying to go with making the steps the user has to take minimal (a few things to fix on that front)
I can do that, they just need to wait for everything to spin up first, which I was trying to avoid
It generates the certificate for them, so there's no extra steps. I was trying to keep everything I could in AWS, especially since we see a lot of LetsEncrypt issues coming through CS - this way if they have an AWS admin they might be able to do more troubleshooting |
So what is remaining: move this to root (eg: |
Co-authored-by: Pierre-Alexandre St-Jean <pa@stjean.me>
Files and instructions for deploying the SCIM Bridge to AWS using ECS Fargate and terraform