Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECS Terraform Fargate Deployment #127

Merged
merged 17 commits into from
Dec 21, 2020
Merged

ECS Terraform Fargate Deployment #127

merged 17 commits into from
Dec 21, 2020

Conversation

accraw
Copy link
Contributor

@accraw accraw commented Dec 16, 2020

Files and instructions for deploying the SCIM Bridge to AWS using ECS Fargate and terraform

Copy link
Contributor

@pastjean pastjean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go with the moto: "Let's try to keep the example minimal"

You are assuming people manage dns with route 53, i'd remove any route 53 requirement and just says "make sure you have a CNAME or A record pointing to the ECS load balancer"
(which is in the prerequisite.md at root IIRC)

From what I read you are not using Let's encrypt stuff but AWS signing, that means that the client needs to have was certificates and ACM set up ? I know this is tricky though to use lets encrypt instead. It might also be ok.

aws-terraform/ecs/terraform.tf Outdated Show resolved Hide resolved
aws-terraform/ecs/task-definitions/scim.json Outdated Show resolved Hide resolved
aws-terraform/ecs/README.md Outdated Show resolved Hide resolved
aws-terraform/ecs/README.md Outdated Show resolved Hide resolved
aws-terraform/ecs/README.md Outdated Show resolved Hide resolved
aws-terraform/ecs/README.md Outdated Show resolved Hide resolved
aws-terraform/ecs/README.md Outdated Show resolved Hide resolved
aws-terraform/ecs/task-definitions/scim.json Outdated Show resolved Hide resolved
@accraw
Copy link
Contributor Author

accraw commented Dec 16, 2020

I'll go with the moto: "Let's try to keep the example minimal"

I was trying to go with making the steps the user has to take minimal (a few things to fix on that front)

You are assuming people manage dns with route 53, i'd remove any route 53 requirement and just says "make sure you have a CNAME or A record pointing to the ECS load balancer"
(which is in the prerequisite.md at root IIRC)

I can do that, they just need to wait for everything to spin up first, which I was trying to avoid

From what I read you are not using Let's encrypt stuff but AWS signing, that means that the client needs to have was certificates and ACM set up ? I know this is tricky though to use lets encrypt instead. It might also be ok.

It generates the certificate for them, so there's no extra steps. I was trying to keep everything I could in AWS, especially since we see a lot of LetsEncrypt issues coming through CS - this way if they have an AWS admin they might be able to do more troubleshooting

aws-terraform/ecs/README.md Outdated Show resolved Hide resolved
aws-terraform/ecs/README.md Outdated Show resolved Hide resolved
aws-terraform/ecs/README.md Outdated Show resolved Hide resolved
aws-terraform/ecs/README.md Outdated Show resolved Hide resolved
@pastjean
Copy link
Contributor

pastjean commented Dec 17, 2020

So what is remaining: move this to root (eg:/aws-ecsfargate-terraform) and add it to the list in /README.md. Mark the other terraform deployment as deprecated

@accraw accraw merged commit d9c26b7 into master Dec 21, 2020
@accraw accraw deleted the ecs branch December 21, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants