Add ReadMe plugin #106
Merged
Add ReadMe plugin #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still figuring out this whole go thing lol feedback: 1Password#107 (comment)
spoke with @Dashron and this might change
There was a problem hiding this comment.
Love it! Thanks for contributing @kanadgupta! I've just left a few last nitpicks for you to consider, overall this looks great! I love the detail in your MR, including using the subdomain as naming suggestion for the 1Password item, the inclusion of the configuration file importer and adding these tests! 🙌
Welcome to the ecosystem ReadMe! 😍
kanadgupta
requested review from
SimonBarendse
and removed request for
DCKcode
|
(oops, didn't mean to remove the review request for @DCKcode, sorry!) |
|
This looks great - thanks for your contribution! |
DCKcode
previously approved these changes
Dec 15, 2022
Co-authored-by: Simon Barendse <SimonBarendse@users.noreply.github.com>
SimonBarendse
previously approved these changes
Dec 15, 2022
DCKcode
previously approved these changes
Dec 15, 2022
volodymyrZotov
previously approved these changes
Dec 15, 2022
kanadgupta
dismissed stale reviews from volodymyrZotov, DCKcode, and SimonBarendse
via
a6516ba
|
(sorry folks, just fixing up a linting error!) |
kanadgupta
requested review from
DCKcode,
SimonBarendse and
volodymyrZotov
and removed request for
DCKcode,
SimonBarendse and
volodymyrZotov
volodymyrZotov
previously approved these changes
Dec 15, 2022
kanadgupta
requested review from
SimonBarendse
and removed request for
DCKcode
DCKcode
previously approved these changes
Dec 15, 2022
kanadgupta
dismissed stale reviews from DCKcode and volodymyrZotov
via
b9289d2
|
So sorry y'all, I was playing around locally and realized that it doesn't make sense for us to include |
DCKcode
approved these changes
Dec 16, 2022
volodymyrZotov
approved these changes
Dec 16, 2022
SimonBarendse
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks, big 1Password fans over here at ReadMe! Looking forward to being a part of this exciting new ecosystem 💙
I still have a few small outstanding TODOs in this PR (that I'll address before officially marking this as ready for review), but the main outstanding issue is that I'm running into is that the env variableRDME_API_KEYisn't properly being provisioned in my testing 😕 see #107 for more information!EDIT: fixed, thanks for your help @SimonBarendse @florisvdg!
Closes #108