New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MongoDB Atlas CLI, with environment variable based importing and provisioning #198
Conversation
…port and provisioning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me overall, I just left a few nitpicks. Awesome job @joqim , thanks for contributing!
I think supporting the environment variables - public/private key-pair - workflow for now is a good approach. We could introduce the config file auth flow further down the line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see your first PR, Joqim! 🎉
Overall, it looks good to me but I left one comment here to discuss further about the credential name.
Thank you for your feedback. I'll address these recommendations as soon as possible. |
I've addressed your changes, please take a look into it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current changes look good to me too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate the contribution! Thank you for taking the time to submit ❤️
…ntial Co-authored-by: Floris van der Grinten <floris@grinten.com> Co-authored-by: Simon Barendse <SimonBarendse@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-approving
This PR adds support for the MongoDB Atlas CLI. This is different from the core MongoDB CLI.
Core features
Main issues
access token
, andrefresh token
.This is my first time contributing to Shell Plugins, feedback welcome. Thanks, @arunsathiya, for getting me started with 1Password and Shell Plugins.