New plugin: AWS CDK Toolkit #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyTitu
reviewed
Mar 30, 2023
There was a problem hiding this comment.
We would like to leverage the powers of CredentialUsage field of an Executable to specify that AWS CDK CLI executable could use the exact same CredentialType as AWS does. This will mean that by default, all default provisioners and importers will be re-used for cdk as well.
@AndyTitu I believe that the change that I just pushed conforms with that you're hoping for. Let me know if you think any other changes are necessary! |
florisvdg
reviewed
Mar 31, 2023
hculea
reviewed
Mar 31, 2023
hculea
reviewed
Mar 31, 2023
Merged
AndyTitu
approved these changes
Apr 5, 2023
SimonBarendse
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for a new plugin for the AWS CDK Toolkit.
The AWS Cloud Development Kit (AWS CDK) lets you define your cloud infrastructure as code in one of its supported programming languages. You can use it to create, manage, deploy, etc. AWS CDK apps.
Thought Process
The AWS CDK Toolkit uses the same credentials as the regular AWS CLI, and the same profile workflow. We can reuse the importers and provisioners that have already been created for the AWS shell plugin.
How To Test
op plugin init cdkcdkcommand from the CDK app directory that requires authentication, e.g.cdk deploy. Try authenticating in the following ways. The command should be authenticated and run as expected:a. Use an existing
AWS Access Keycreated for the regular AWS shell pluginb. Import credentials from the
~/.aws/credentialsfilec. Import credentials manually as prompted
make aws/validate. All validation checks should pass and there should be a# Executable: AWS CDK Toolkitsection