Correct ngrok credential lengths

[williamhpark]

Resolves: #249

The lengths of the ngrok credentials specified in ngrok/credentials.go seem to be incorrect. The correct lengths should be:

• Authtoken: 49
• API key: 49

You can create the secrets using these links:

• https://dashboard.ngrok.com/get-started/your-authtoken
• https://dashboard.ngrok.com/api

The incorrect length values don't seem to affect any functionality at the moment, but it's important to record the correct values for future features, e.g. any case where validating extracted credentials is needed.

[arunsathiya]

Great spot, @williamhpark! I am not sure why I had entered 43 and 48. 49 does seem to be correct length (confirmed both by checking my old authtoken and API key, and by generating new ones on the ngrok website)

Could we regenerate the new example secrets with make ngrok/example-secrets and add them to these files?

• plugins/ngrok/credentials_test.go
• plugins/ngrok/test-fixtures/config.yml

[arunsathiya]

I am not seeing anything on the changelog either that suggests that this is a new change.

[williamhpark]

Great spot, @williamhpark! I am not sure why I had entered 43 and 48. 49 does seem to be correct length (confirmed both by checking my old authtoken and API key, and by generating new ones on the ngrok website)

Could we regenerate the new example secrets with make ngrok/example-secrets and add them to these files?

• plugins/ngrok/credentials_test.go
• plugins/ngrok/test-fixtures/config.yml

@arunsathiya Ah thanks for catching that, done!

[accraw]

Makes sense to me!