Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

civo plugin added #286

Closed
wants to merge 4 commits into from
Closed

civo plugin added #286

wants to merge 4 commits into from

Conversation

itsCheithanya
Copy link
Contributor

Overview

Type of change

  • Created a new plugin
  • Improved an existing plugin
  • Fixed a bug in an existing plugin
  • Improved contributor utilities or experience

Related Issue(s)

  • Resolves: #
  • Relates: #

How To Test

Install Civo CLI
https://www.civo.com/docs/overview/civo-cli
Test the plugin by running
op plugin init civo
civo region ls
image

Changelog

Copy link
Contributor

@arunsathiya arunsathiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @itsCheithanya, thank you for your contribution! 🙌🏼

I haven't taken a proper look at the proposed changes yet, but can move forward with a couple of things:

I'll mark this PR as in progress, and don't hesitate to ping me if you have any questions.

@arunsathiya arunsathiya added the in-progress this PR is being worked on/comments are in the process of being addressed by the contributor label Jun 12, 2023
@itsCheithanya
Copy link
Contributor Author

Heyy @arunsathiya I have done all the required changes and additions
Thankyouu

@arunsathiya
Copy link
Contributor

Also @itsCheithanya, I just noticed that your commits aren't signed. Could you set up commit signing and rebase all previous commits before we move further along? This comment can help, and more specifically, commit signing is easy to set up with 1Password.

@itsCheithanya
Copy link
Contributor Author

itsCheithanya commented Jun 13, 2023

okay @arunsathiya should I rebase civo branch to main branch by typing
git rebase main
image
I tried to rebase its giving me this can u help me understand why is this happening
I followed the commit signing setup

@arunsathiya arunsathiya added waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member and removed in-progress this PR is being worked on/comments are in the process of being addressed by the contributor labels Jun 13, 2023
@arunsathiya
Copy link
Contributor

Glad commit signing is set up! Regarding rebase the commits to be verified, could you run git rebase --exec "git commit --amend --no-edit -n -S" -i 8fd7b22 (where 8fd7b22 should be replaced with the commit ID just before you started your work) instead of just git rebase main as outlined on this Stack Overflow answer?

@arunsathiya
Copy link
Contributor

arunsathiya commented Jun 13, 2023

You can run git log --pretty=oneline to find all the commits on your branch. Since your work started at 6a5678b, you'd run that rebase command with the commit ID just before 6a5678b.

@itsCheithanya
Copy link
Contributor Author

itsCheithanya commented Jun 14, 2023

I did everything you said, but it still gives me an error. Should I submit a new PR?
image
image

@arunsathiya
Copy link
Contributor

Hmm, @itsCheithanya, I am not too sure what's happening here but going by the number of commits that show this error, I suspect that the rebase occurred for commits besides your original ones as well? I don't know for sure; it's my first time using interactive rebasing.

At this point, a new PR would be ideal! Feel free to ping me on that PR when it's up.

@itsCheithanya
Copy link
Contributor Author

itsCheithanya commented Jun 15, 2023

@arunsathiya I've created on more PR on this

@arunsathiya
Copy link
Contributor

Closing this PR in favor of the other one:

@arunsathiya arunsathiya removed the waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member label Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants