Docker Shell Plugin #300
Docker Shell Plugin #300
Conversation
AndyTitu
added
the
in-progress
|
Converting to draft as this is still Work In Progress |
|
Hi @roy9495, I believe this submission is for the Hashnode Hackathon. There's ongoing work for a Docker shell plugin here from @itsCheithanya: May I suggest that you two collaborate to get this to the finish line? We will be counting this contribution for both of you for the hackathon. Please let me know if that is okay with you and whether I could help you two connect, on Discord or the 1Password Developer Workspace on Slack! |
| } | ||
|
|
||
| var defaultEnvVarMapping = map[string]sdk.FieldName{ | ||
| "DOCKERHUB_TOKEN": fieldname.Token, // TODO: Check if this is correct |
There was a problem hiding this comment.
@roy9495 Are you sure DOCKERHUB_TOKEN exists and is interpreted by Docker CLI? I couldn't get this to work
There was a problem hiding this comment.
No sir, I am not sure but here it was mentioned. So, I used it. I could not set it up on my PC, so I set it up on Gitpod.
|
|
Also don't forget to submit your Hashnode blog post with the 1Password and BuildWith1Password tags. (Hashnode tags - just #1Password in the blog post text. The full instructions are here. |
|
@techcraver Ok sir, I will surely do that. |
Sure let's collaborate |
|
Hey @roy9495, just wanted to give you an update about this - I am going to close this PR, since currently Cheithanya's PR (#301) is in a more mature state, so you can both pick up from there, at a later point. 😄 That being said, we figured that Docker is a tool that will involve some internal changes for the plugin ecosystem to support, so we're not proceeding with this plugin for the time being. Thank you for your contribution, and we welcome you to contribute new plugins to the ecosystem in the future! ❤️ |
|
Ok sir |
Overview
Docker Shell Plugin Created
Type of change
Related Issue(s)
How To Test
Changelog