Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Pipedream CLI #338

Merged
merged 4 commits into from Jul 25, 2023
Merged

Conversation

rajapri28613
Copy link
Contributor

Overview

Add support for Pipedream CLI. The shell plugin provisions a configuration file at ~/.config/pipedream/config. The shell plugin also imports the API Key and the Org ID from the same file at the same path, if they exist.

Type of change

  • Created a new plugin
  • Improved an existing plugin
  • Fixed a bug in an existing plugin
  • Improved contributor utilities or experience

Related Issue(s)

  • Resolves: #
  • Relates: #

How To Test

  • Install Pipedream CLI and set up the shell plugin.
  • If the config file exists at ~/.config/pipedream/config, the first time op plugin init pd is run, the API Key and Org ID can be imported into 1Password.
  • Test with pd login status. It should show that the login is successful.

Changelog

Add support for Pipedream CLI

Additional information

@rajapri28613
Copy link
Contributor Author

@arunsathiya arunsathiya added waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member hashnode hackathon Ideas and inspiration for the hackathon running from June 1st - June 30th labels Jul 3, 2023
@hculea hculea requested review from arunsathiya and AndyTitu and removed request for arunsathiya July 5, 2023 07:32
Copy link
Contributor

@arunsathiya arunsathiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good start, thank you for your contribution @rajapri28613! I have left a few comments to address before we can move forward, including building support for importing multiple profile credentials.

plugins/pipedream/api_key.go Outdated Show resolved Hide resolved
plugins/pipedream/api_key.go Show resolved Hide resolved
plugins/pipedream/api_key.go Show resolved Hide resolved
plugins/pipedream/pd.go Show resolved Hide resolved
@arunsathiya arunsathiya added in-progress this PR is being worked on/comments are in the process of being addressed by the contributor and removed waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member labels Jul 12, 2023
@arunsathiya arunsathiya self-requested a review July 12, 2023 11:52
@arunsathiya arunsathiya added waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member and removed in-progress this PR is being worked on/comments are in the process of being addressed by the contributor labels Jul 19, 2023
Copy link
Contributor

@arunsathiya arunsathiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both importer and provisioner work fine. Thanks for the contribution!

@accraw accraw added waiting-on-sec-review and removed waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member labels Jul 24, 2023
Copy link
Member

@SimonBarendse SimonBarendse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate your contribution!

I have left a tiny suggestion for your consideration.

plugins/pipedream/api_key.go Outdated Show resolved Hide resolved
Co-authored-by: Simon Barendse <SimonBarendse@users.noreply.github.com>
@arunsathiya arunsathiya merged commit 3eaa0d5 into 1Password:main Jul 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashnode hackathon Ideas and inspiration for the hackathon running from June 1st - June 30th
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants