Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Todoist CLI #340

Merged
merged 3 commits into from Aug 15, 2023
Merged

Conversation

rajapri28613
Copy link
Contributor

Overview

Add support for Todoist CLI. The shell plugin provisions a configuration file at ~/.config/todoist/config.json. The shell plugin also imports the Todoist token from the same file at the same path, if it exists.

Type of change

  • Created a new plugin
  • Improved an existing plugin
  • Fixed a bug in an existing plugin
  • Improved contributor utilities or experience

Related Issue(s)

  • Resolves: #
  • Relates: #

How To Test

  • Install Todoist CLI and set up shell plugin.
  • Run op plugin init todoist to import the token from ~/.config/todoist/config.json
  • The next time todoist commands are run, the shell plugin provisions the token to the same file path.

Changelog

Add support for Todoist CLI.

Additional information

@rajapri28613
Copy link
Contributor Author

@arunsathiya arunsathiya added waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member hashnode hackathon Ideas and inspiration for the hackathon running from June 1st - June 30th labels Jul 3, 2023
@hculea hculea requested review from AndyTitu and hculea and removed request for AndyTitu and hculea July 5, 2023 07:31
plugins/todoist/todoist.go Outdated Show resolved Hide resolved
@accraw
Copy link
Contributor

accraw commented Jul 24, 2023

The functional test worked ✅ The only thing that wasn't as expected was the command with no args.

@accraw accraw added in-progress this PR is being worked on/comments are in the process of being addressed by the contributor and removed waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member labels Jul 24, 2023
Copy link
Contributor

@arunsathiya arunsathiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this functionally and code proposal looks good to me. There's only one minor comment about the test file format for your consideration. Thanks for the contribution!

Approving with the assumption that it'll be updated.

plugins/todoist/api_token.go Outdated Show resolved Hide resolved
@arunsathiya arunsathiya added waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member and removed in-progress this PR is being worked on/comments are in the process of being addressed by the contributor labels Jul 26, 2023
@arunsathiya arunsathiya requested a review from accraw July 26, 2023 01:50
@arunsathiya arunsathiya added waiting-on-sec-review and removed waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member labels Aug 14, 2023
@arunsathiya arunsathiya merged commit 70bc8ee into 1Password:main Aug 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashnode hackathon Ideas and inspiration for the hackathon running from June 1st - June 30th
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants