Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Crowdin CLI #359

Merged
merged 7 commits into from Aug 15, 2023
Merged

Add support for Crowdin CLI #359

merged 7 commits into from Aug 15, 2023

Conversation

JoeKarow
Copy link
Contributor

Overview

Add support for the Crowdin CLI

Type of change

  • Created a new plugin
  • Improved an existing plugin
  • Fixed a bug in an existing plugin
  • Improved contributor utilities or experience

Related Issue(s)

  • Resolves: #
  • Relates: #

How To Test

When inside of a Crowdin project with a crowdin.yml file, run a command such as crowdin list branches

Changelog

Authenticate the Crowdin CLI using Touch ID and other unlock options with 1Password Shell Plugins.
The Crowdin plugin can be initialized with a Crowdin Personal Token, an optional Project ID, and a Base URL (for Crowdin Enterprise) using op plugin init crowdin. Please see the Crowdin documentation to ensure your project is set up to authenticate via environment variables.

Copy link
Contributor

@arunsathiya arunsathiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good start, thank you for your contribution @JoeKarow! I have only one comment to discuss about the config file importer.

plugins/crowdin/access_token.go Outdated Show resolved Hide resolved
plugins/crowdin/access_token.go Outdated Show resolved Hide resolved
plugins/crowdin/access_token.go Outdated Show resolved Hide resolved
plugins/crowdin/access_token.go Show resolved Hide resolved
@arunsathiya arunsathiya added the waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member label Jul 26, 2023
@arunsathiya arunsathiya requested a review from accraw July 26, 2023 14:58
Copy link
Contributor

@arunsathiya arunsathiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving! For other reviewers on this PR, here's a comment you may want to read too.

Copy link
Contributor

@AndyTitu AndyTitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm

@arunsathiya arunsathiya added waiting-on-sec-review and removed waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member labels Aug 11, 2023
Copy link
Member

@jpcoenen jpcoenen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@arunsathiya arunsathiya merged commit 4f5f184 into 1Password:main Aug 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants