feat(sentry): add SENTRY_PROJECT & SENTRY_URL
#363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunsathiya
added
the
waiting-on-reviewer
arunsathiya
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
These changes look good to me, and functional test successful. Thanks for the PR, @JoeKarow!
arunsathiya
added
waiting-on-sec-review
and removed
waiting-on-reviewer
|
Thanks for your contribution 🙌 Looks good! |
jpcoenen
approved these changes
Aug 15, 2023
arunsathiya
approved these changes
Aug 15, 2023
jpcoenen
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added configuration for
SENTRY_PROJECT&SENTRY_URLenv vars. [Docs]Type of change
Related Issue(s)
How To Test
Run
sentry-cli info. The configured values forSENTRY_PROJECT&SENTRY_URLshould show:Sentry Server: https://sentry.io Default Organization: acme Default Project: example Authentication Info: Method: Auth Token User: user@example.com Scopes: - event:admin - event:read - member:read - org:read - project:read - project:releases - team:readChangelog
Added support for
SENTRY_PROJECT&SENTRY_URL.