Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LocalStack plugin #371

Merged
merged 3 commits into from Sep 21, 2023
Merged

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented Aug 17, 2023

Overview

LocalStack is "a fully functional local cloud stack, to develop and test your cloud and serverless apps offline"..

This PR adds support for setting the API key for use with LocalStack's pro offering.

Disclaimer: I work for LocalStack

Type of change

  • Created a new plugin
  • Improved an existing plugin
  • Fixed a bug in an existing plugin
  • Improved contributor utilities or experience

How To Test

# configure your shell for using the plugin
localstack start
# LocalStack reads the API key from 1Password, and enables pro mode

Copy link
Contributor

@AndyTitu AndyTitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm. @simonrw It would be great if you could share some screenshot/video of the plugin working. Anyway, I'm approving the code for the time being.

Copy link
Member

@SimonBarendse SimonBarendse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the contribution @simonrw! ❤️

Disclaimer: I work for LocalStack

And welcome to the ecosystem, LocalStack! 🎉 Great to have you here.

@SimonBarendse SimonBarendse merged commit 7402bad into 1Password:main Sep 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants