Add file importer for cachix plugin #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyTitu
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Security review approved.
I just have a small suggestion to make the implementation robust for potential future extensions by Cachix.
Appreciate the contribution, @dethancosta! ❤️
SimonBarendse
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a file importer for the Cachix plugin. The file is stored at
~/.config/cachix/cachix.dhalland is generated from a terminal command. To avoid bringing in a third-party dependency, the file contents are processed as a string, rather than using a dhall parser.Type of change
Related Issue(s)
How To Test
When running
op plugin init cachix, you should now see the option to import credentials using the specified file.Changelog
The Cachix plugin now checks for the
~/.config/cachix/cachix.dhallfile and attempts to import an auth token using the specified file.