-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker plugin #386
Add Docker plugin #386
Conversation
Note that from the Docker binary's perspective, the password is being entered in plaintext on the command line, so it will emit a warning. |
Thank you very much for your contribution! It doesn't look like this approach will work consistently. We like the third option you suggested, and have even sketched out a solution in this comment: #301 (comment) I don't think this will require work on the cli side, it should be possible with just shell-plugins, but that's something that would be figured out once someone really starts to dig into this. If you don't want to take this on, it's on our radar to add but not in the immediate future, in case that influences your decision. |
Ah, apologies, I didn't realize there was a previous PR with the same approach. I'll take a crack at the sketched out solution possibly after the weekend, if that's alright. |
Absolutely, that would be awesome! |
This merge updates the docker plugin code to use/implement a credential helper
Alright, I think I've implemented all the credential helper functionality, but with a few issues/caveats that I'm not sure how to resolve:
This PR likely isn't mergeable, but I figured I'd at least document the issues I ran into attempting this approach. |
Thank you so much for taking the time to try this out! You're making a compelling case for docker to be added as a plugin internally, for now I'm going to close this PR and anyone who picks it up can reference it. |
Overview
Adds a plugin to authenticate the Docker CLI using a username and secret (a password or an access token).
Type of change
Related Issue(s)
How To Test
docker login
Changelog
Authenticate to a Docker registry using Touch ID and other unlock options with 1Password Shell Plugins.