Derive field name in make new-plugin more intelligently #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of always using the last word of the credential name as the field name, also take the second to last word if the result is not too lengthy (e.g. API Key).
AndyTitu
approved these changes
Dec 7, 2022
SimonBarendse
approved these changes
Dec 12, 2022
hculea
approved these changes
Dec 12, 2022
This was referenced May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
make new-plugin, instead of always using the last word of the credential name as the field name, also take the second to last word if the resulting field name is not too lengthy.For example:
The 7 value is arbitrary and can be changed later if we feel like it.
This new field name is also used as the env var name:
Previously, we'd derive
GITHUB_PERSONAL_ACCESS_TOKEN, but now it would beGITHUB_TOKEN.