fix: fix op cli always generating passwords #127
Conversation
When invoking the op cli, if the onepassword item had no password recipe, generate-password would always be appended to the cli args and any password value would be overwritten by a generated password
There was a problem hiding this comment.
Thank you so much for providing a fix for the bug mentioned in #128. I really appreciate it. 💪🏻
Functional review: ✅
Validated that this code will no longer generate passwords when creating an item and the user provided a custom value to the password.
Code review: ✅
Code looks clean and straight forward. I really appreciate you extracting the functionality for getting the password recipe for an item, as well as writing tests for that new functionality.
I left one nitpick that would simplify some code, however the current implementation is good already.
Other notes
Could you add in the PR description that it resolves issue #128? In this way, when we merge this PR, the issue will close automatically. 😄
Adding this line should suffice:
Resolves: #128 
|
@edif2008 thanks for the review :) I've updated the PR description and applied your suggestion. |
When invoking the op cli, if the onepassword item had no password recipe, generate-password would always be appended to the cli args and any password value would be overwritten by a generated password.
Note I am very new to Go so please point me in the right direction if needed :)
As part of this fix I have extracted the logic which constructs the generate-password cli arg into a function in utils, and implemented a test around it.
Fixes #128