Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import from CSV from mRemoteNG doesn't work #30

Closed
majkinetor opened this issue Dec 8, 2020 · 6 comments
Closed

Import from CSV from mRemoteNG doesn't work #30

majkinetor opened this issue Dec 8, 2020 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@majkinetor
Copy link
Member

majkinetor commented Dec 8, 2020

Describe the bug

mRemoteNG v1.77.1.27713 (installed from Choclatey: cinst mremoteng)

To Reproduce

Not sure. Here is 1 CSV line with header and password set to ****:

Name;Id;Parent;NodeType;Description;Icon;Panel;Username;Password;Domain;Hostname;VmId;Protocol;PuttySession;Port;ConnectToConsole;UseCredSsp;UseVmId;RenderingEngine;ICAEncryptionStrength;RDPAuthenticationLevel;LoadBalanceInfo;Colors;Resolution;AutomaticResize;DisplayWallpaper;DisplayThemes;EnableFontSmoothing;EnableDesktopComposition;CacheBitmaps;RedirectDiskDrives;RedirectPorts;RedirectPrinters;RedirectClipboard;RedirectSmartCards;RedirectSound;RedirectKeys;PreExtApp;PostExtApp;MacAddress;UserField;ExtApp;Favorite;VNCCompression;VNCEncoding;VNCAuthMode;VNCProxyType;VNCProxyIP;VNCProxyPort;VNCProxyUsername;VNCProxyPassword;VNCColors;VNCSmartSizeMode;VNCViewOnly;RDGatewayUsageMethod;RDGatewayHostname;RDGatewayUseConnectionCredentials;RDGatewayUsername;RDGatewayPassword;RDGatewayDomain;RedirectAudioCapture;RdpVersion;InheritCacheBitmaps;InheritColors;InheritDescription;InheritDisplayThemes;InheritDisplayWallpaper;InheritEnableFontSmoothing;InheritEnableDesktopComposition;InheritDomain;InheritIcon;InheritPanel;InheritPassword;InheritPort;InheritProtocol;InheritPuttySession;InheritRedirectDiskDrives;InheritRedirectKeys;InheritRedirectPorts;InheritRedirectPrinters;InheritRedirectClipboard;InheritRedirectSmartCards;InheritRedirectSound;InheritResolution;InheritAutomaticResize;InheritUseConsoleSession;InheritUseCredSsp;InheritUseVmId;InheritVmId;InheritRenderingEngine;InheritUsername;InheritICAEncryptionStrength;InheritRDPAuthenticationLevel;InheritLoadBalanceInfo;InheritPreExtApp;InheritPostExtApp;InheritMacAddress;InheritUserField;InheritFavorite;InheritExtApp;InheritVNCCompression;InheritVNCEncoding;InheritVNCAuthMode;InheritVNCProxyType;InheritVNCProxyIP;InheritVNCProxyPort;InheritVNCProxyUsername;InheritVNCProxyPassword;InheritVNCColors;InheritVNCSmartSizeMode;InheritVNCViewOnly;InheritRDGatewayUsageMethod;InheritRDGatewayHostname;InheritRDGatewayUseConnectionCredentials;InheritRDGatewayUsername;InheritRDGatewayPassword;InheritRDGatewayDomain;InheritRDPAlertIdleTimeout;InheritRDPMinutesToIdleTimeout;InheritSoundQuality;InheritRedirectAudioCapture;InheritRdpVersion
vm-mmilic [nil];dc6cb033-b673-4aaf-b4d4-b4c05a06fddb;1364dba9-2097-4fb4-b8f2-ab9232618777;Connection;vm-1-dev-mmilic;mRemoteNG;General;nil.com\mmilic;*********;nil.com;vm-mmilic;;RDP;Default Settings;3389;False;True;False;IE;EncrBasic;NoAuth;;Colors16Bit;FitToWindow;True;True;True;True;True;True;True;False;False;True;False;DoNotPlay;True;;;;;;True;CompNone;EncHextile;AuthVNC;ProxyNone;;0;;;ColNormal;SmartSAspect;False;Never;;Yes;;;;False;Highest;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;False;

Expected behavior

It shows success. Nothing else. No number of items, imported items, errors and so on...

Desktop (please complete the following information):
OS Name: Microsoft Windows 10 Pro
OS Version: 10.0.19042 N/A Build 19042

  • PRemoteM Version: 0.5.5.2012072119 (please make it copy/pastable in about box)

Additional context
Nothing, just wanted to try alternative to mRemoteNg. It looks like WIP but I totally like it so far, its way faster to resize and has saner config.

Also, as related now, UI buttons text are cut:

image

@majkinetor majkinetor added the bug Something isn't working label Dec 8, 2020
@VShawn
Copy link
Member

VShawn commented Dec 9, 2020

bug fixed hot-fix release is coming soon, thanks for your report.

image

VShawn@6470214 bring in this bug by error logic

UI buttons text are cut

no idea, UI works good for me 😕

image

@majkinetor
Copy link
Member Author

Regarding cut, my Windows is set to 125% which is probably the reason why:

image

@VShawn VShawn closed this as completed in b24d3b6 Dec 9, 2020
VShawn added a commit that referenced this issue Dec 9, 2020
2. improve for #22 https://github.com/VShawn/PRemoteM/issues/22#issuecomment-740849283
3. improve for #26 https://github.com/VShawn/PRemoteM/issues/26#issuecomment-740859060
4. right click link to import language json file.

Signed-off-by: Shawn <singlex@foxmail.com>
@majkinetor
Copy link
Member Author

Its still a bug with 125%, you should take that into account when refactoring UI, otherwise, you can call it pedantic.

@VShawn
Copy link
Member

VShawn commented Dec 9, 2020

Its still a bug with 125%, you should take that into account when refactoring UI, otherwise, you can call it pedantic.

that's it, it is the reason of cut off, no idea how to fix it now. Google for solution latter when i back home : )


BTW, new version to fix bugs has been released https://github.com/VShawn/PRemoteM/releases/tag/0.5.5.2012072119

@majkinetor
Copy link
Member Author

majkinetor commented Dec 9, 2020

It works now, it imported all my mRemoteNg stuff.

However, it imports containers as items, not groups. mREmoteNG has nodeType Container which is similar to your groups (albeit better since you can't have groups within groups). It would be nice to import at least 1 level containers or make it equivalent in features as mRemoteNg.

Also, in mRemoteNG containers provide common parameters via inheritance, but that is some other topic.

image

vs

image

VShawn added a commit that referenced this issue Dec 9, 2020
2. improve mremoteng import: group #30

Signed-off-by: Shawn <singlex@foxmail.com>
VShawn added a commit that referenced this issue Dec 9, 2020
2. improve mremoteng import: group #30

Signed-off-by: Shawn <singlex@foxmail.com>
VShawn added a commit that referenced this issue Dec 9, 2020
2. improve mremoteng import: group #30

Signed-off-by: Shawn <singlex@foxmail.com>
@VShawn
Copy link
Member

VShawn commented Dec 9, 2020

However, it imports containers as items, not groups. mREmoteNG has nodeType Container which is similar to your groups (albeit better since you can't have groups within groups). It would be nice to import at least 1 level containers or make it equivalent in features as mRemoteNg.

https://github.com/VShawn/PRemoteM/blob/dev/PRM.Core/Model/SystemConfig.DataSecurity.cs#L731-L770

i pull a new release to fix this.

VShawn added a commit that referenced this issue Jan 21, 2021
VShawn added a commit that referenced this issue Dec 23, 2021
VShawn added a commit that referenced this issue Dec 23, 2021
2. improve for #22 https://github.com/VShawn/PRemoteM/issues/22#issuecomment-740849283
3. improve for #26 https://github.com/VShawn/PRemoteM/issues/26#issuecomment-740859060
4. right click link to import language json file.

Signed-off-by: Shawn <singlex@foxmail.com>
VShawn added a commit that referenced this issue Dec 23, 2021
2. improve mremoteng import: group #30

Signed-off-by: Shawn <singlex@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants