Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If autostart option is selected, UAC prompt is shown even if you just exit the options #31

Closed
majkinetor opened this issue Dec 8, 2020 · 2 comments
Closed

If autostart option is selected, UAC prompt is shown even if you just exit the options #31

majkinetor opened this issue Dec 8, 2020 · 2 comments
Assignees
@VShawn
Labels
bug Something isn't working

Comments

@majkinetor
Copy link
Member

Describe the bug

Enable autostart in options, say yes in UAC, go Back, say YES again?

Now just enter options and exit, UAC will prompt

Expected behavior

Do not show UAC prompt when there is no admin changes.
@majkinetor majkinetor added the bug Something isn't working label Dec 8, 2020
@VShawn
Copy link
Member

VShawn commented Dec 9, 2020 •
edited

the fact is in win32 version, i create/delete shutcut in

C:\ProgramData\Microsoft\Windows\Start Menu\Programs\StartUp

it needs admin authorization, so UAC show up.

But it is weird that UAC prompt twice, I will go for a check, it only prompt onece in previous version.

BTW, if you are using Stroe version, there should be on UAC prompt.

Update

found I miss some code during refactor of the class SetSelfStartingHelper which brings this bug.

VShawn added a commit that referenced this issue Dec 9, 2020
@VShawn
1. bug fix close #30 #31
b24d3b6 
2. improve for #22 https://github.com/VShawn/PRemoteM/issues/22#issuecomment-740849283
3. improve for #26 https://github.com/VShawn/PRemoteM/issues/26#issuecomment-740859060
4. right click link to import language json file.

Signed-off-by: Shawn <singlex@foxmail.com>
VShawn added a commit that referenced this issue Dec 9, 2020
@VShawn
1. bug fix close #30 #31
4e6ab08 
2. improve for #22 https://github.com/VShawn/PRemoteM/issues/22#issuecomment-740849283
3. improve for #26 https://github.com/VShawn/PRemoteM/issues/26#issuecomment-740859060
4. right click link to import language json file.

Signed-off-by: Shawn <singlex@foxmail.com>
@VShawn VShawn closed this as completed Dec 9, 2020
@majkinetor
Copy link
Member Author

I confirm this works

VShawn added a commit that referenced this issue Jan 21, 2021
@VShawn
bug fix close #30 #31
cd73554
VShawn added a commit that referenced this issue Dec 23, 2021
@VShawn
bug fix close #30 #31
64a71f4
VShawn added a commit that referenced this issue Dec 23, 2021
@VShawn
1. bug fix close #30 #31
76d9b65 
2. improve for #22 https://github.com/VShawn/PRemoteM/issues/22#issuecomment-740849283
3. improve for #26 https://github.com/VShawn/PRemoteM/issues/26#issuecomment-740859060
4. right click link to import language json file.

Signed-off-by: Shawn <singlex@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VShawn VShawn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@majkinetor @VShawn