-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory Leak #189
Comments
@chiunam : First of, thank you for creating this pod. It looks great. We've just integrated it with our app and are testing it to learn more about it. I also did notice that it uses a lot of memory when scrolling through a large collection of images. On iPhone 6 Plus with 2000 images, the working set starts at 30 MB when the asset picker is first presented, and goes up to almost 200 MB when I scroll through the collection a few times. After a cursory look, it doesn't seem like a memory leak though - eventually, the memory gets cleaned up if I dismiss the picker and present it again. Still, that's a lot of memory. Possibly related to that - scroll performance seems to be an issue on iPhone 6 Plus. I agree with your comment earlier that perf is adequate on iPhone 6, but with more images visible on screen + higher resolution on iPhone 6 Plus, the experience is not smooth. I've spend less than an hour looking at the code so far, but it feels like
with
then scrolling is a lot smoother, and the app ends up using a lot less memory (I couldn't go past 60 MB in the exact same experiment as above). /cc: @chadwilken |
Good find! I would love to get a patch of this soon. If you need help with anything let me know. |
I've updated my PR to include the fix for this: #188. I changed thumbnail request resize mode from |
@chrisze Thanks a a lot for your investigation and contribution. I need some time to study and test your PR. Might not able to merge it in a short time as I am pretty busy recently. @chadwilken Please help to test @chrisze's PR if you are free. |
Guys, sorry for being late. I'm going to merge his PR. Just have to clarify some changes with @chrisze. Stay tuned. |
#189 Fix memory issue and visual bugs
I am using a pretty vanilla setup of the library and simply presenting the view controller and scrolling to the top adds ~40mb to my in use memory. Have you experienced this before and if so do you have a work-around?
The text was updated successfully, but these errors were encountered: