fix crash during device rotation #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some rare cases, UICollectionView may throw an exception while items reloading (http://stackoverflow.com/questions/13929518/). The crash occurs when items size does not fit into CollectionView’s contentSize + offsets. One possible reason of it is the case when (during a rotation) view.bound.size returns a very small rect. This fix trying to catch that case and ignore all the rest code.
|
@Sega-Zero This PR will be merged as pre-release too. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some rare cases, UICollectionView may throw an exception while items reloading (see http://stackoverflow.com/questions/13929518/ for example).
The crash occurs when items size does not fit into CollectionView’s contentSize + offsets or having negative width/height. One possible reason of it is the case when (during a rotation) view.bound.size returns a very small size.
This fix trying to catch that case and ignore all the rest code.
Couldn't reproduce that behavior on a clean project, but that crash occurs pretty frequently on 6+ devices in one of my production projects. It looks like this:
