Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orion editor support is broken; modifications render but do not persist #40

Open
1ec5 opened this Issue Feb 17, 2014 · 3 comments

Comments

Projects
None yet
1 participant
@1ec5
Copy link
Owner

commented Feb 17, 2014

In an Eclipse Orion editor, such as the one here, typing chu+~ in VIQR gets you “chữ”, but as soon as you press any key or click anywhere, the word reverts to “chu”. Effectively, Orion support is just an illusion.

@1ec5 1ec5 added bug labels Feb 17, 2014

@1ec5 1ec5 added this to the 20080728.523 milestone Feb 17, 2014

@1ec5 1ec5 self-assigned this Feb 17, 2014

@1ec5

This comment has been minimized.

Copy link
Owner Author

commented Feb 17, 2014

The original Orion support, which I wrote years ago, assumed (correctly at the time) that the originalTarget would be div#clientDiv.editorContent. Orion’s frontend appears to have been rewritten since then, so now AVIM falls back on contenteditable support, which doesn’t touch Orion’s model.

@1ec5 1ec5 removed this from the 20080728.523 milestone Feb 20, 2014

@1ec5

This comment has been minimized.

Copy link
Owner Author

commented Feb 20, 2014

In fact, no IME extension on either Firefox or Chrome works with Orion. Google Input Tools comes the closest, allowing you to enter an entire word before the word disappears. On the Mac at least, even system IMEs have trouble with Orion: after committing a composition, you can no longer start a new composition.

1ec5 added a commit that referenced this issue Feb 20, 2014

@1ec5 1ec5 referenced this issue Feb 20, 2014

Closed

GitHub Pages #22

@1ec5

This comment has been minimized.

Copy link
Owner Author

commented Feb 23, 2014

originalTarget is now div.textviewContent. Some Orion functionality can be accessed through window.orion and window.orion.editor, but everything else is neatly hidden away. It seems like most AVIM’s ordinary contenteditable support should be adequate, but Orion is listening for the obsolete textinput event instead of input (or compositionstart and compositionend in the case of system IMEs).

@1ec5 1ec5 removed their assignment Feb 24, 2014

1ec5 added a commit that referenced this issue Sep 2, 2014

Removed Orion support
None of this code is active anyways, even in debug builds.

Ref #40.

@1ec5 1ec5 added web apps rich text and removed web apps labels Nov 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.