Lora band define #1231
Merged
Lora band define #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DigiH
force-pushed
the
lora-band-define
branch
2 times, most recently
from
fb818f4
to
d357251
Compare
|
Finally :) I thought my formatter was all set up to read the definition correctly, but obviously it wasn't. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the LORA_BAND defines working properly in the platformio.ini environments and binary builds, not being overwritten by the default define in config_LORA.h, as pointed out in the forum
https://community.openmqttgateway.com/t/heltec-wifi-lora-32-915-option-1-upload-from-the-web-gateway-appears-to-be-set-to-the-wrong-frequency/1933/5
Checklist: