[SYS] Implement a central queue #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1technophile
force-pushed
the
central-queue
branch
3 times, most recently
from
662bfd0
to
0acb6f1
Compare
h2zero
reviewed
Oct 13, 2023
to avoid concurrency issue when modules or/and gateways want to publish data Simplify signature BuildBTtopic outside of main Cherry pick 1736 Improve queue size Simplify Hapresence Allocate json buffer in the heap to avoid overloading the callback
Also check the content of the entries before assignments to the json
1technophile
force-pushed
the
central-queue
branch
from
c9b3380
to
73bc2ea
Compare
1technophile
force-pushed
the
central-queue
branch
from
9a98dfa
to
1481b96
Compare
Indeed the char array used to build the json object does not exist anymore so for the moment we don't use the enqueue method for acknowledgement
1technophile
force-pushed
the
central-queue
branch
from
2b8e7f0
to
ccaedb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
To avoid concurrency issues when modules or/and gateways are publishing data. A queue system was previously in place for the BT gateway. With this PR it is now used by all the modules.
Previously having different modules potentially assigned to different cores was generating MQTT disconnections.
Why not use the FreeRTOS queue management function? I gave it a try but was not satisfied with the stability and got better stability with the stl
Checklist: