Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Symfony 5 and dropped support for Symfony 3 #373

Merged
merged 43 commits into from
Mar 27, 2020
Merged

Add support for Symfony 5 and dropped support for Symfony 3 #373

merged 43 commits into from
Mar 27, 2020

Conversation

bytehead
Copy link
Member

No description provided.

steveWinter and others added 19 commits January 3, 2020 16:43
@steveWinter
Dealing with the modified method signature for UploadedFile which wit…
98b6957 
…h strict type checking in SF 4.4 fails
@steveWinter
SF 4.4 swallows the exception so it never makes it as far as the test
52ddd76
@steveWinter
Adding SF 5.0
cebfb89
@steveWinter
Adding SF 5.0 and updating PHP versions to currently supported
4b3a6a3
@steveWinter
Switching config to support SF 5.0's removal of the kernal.root_dir a…
0bba797 
…nd removal of the templating config variable
@steveWinter
Even for non-uploaded files we have to deal with the new File signatu…
afa1571 
…re otherwise the size ends up as the error
@steveWinter
Explicitly set framework.test to true to prevent Travis test failure
b5eee7e
@steveWinter
Set return type for tearDown method as required by SF 5
9880e29
@gubler
Update to support Twig 3
bf5adbb 
Replace global functions with namespaced functions
@gubler
Add Twig requirement due to Twig Extension
d13850d
@steveWinter
Merge pull request #1 from gubler/master
048a8ee 
Support for Twig 3
@steveWinter
Removing SF 3.4 from Travis as discussed
f800365
@bytehead
Merge branch 'master' of https://github.com/steveWinter/OneupUploader…
ecb7b1f 
…Bundle into feature/symfony-5
@bytehead
Removed Symfony 3.x stuff
9bf5d0c
@bytehead
Remove comment
a79bd13
@bytehead
Merge branch 'master' of github.com:1up-lab/OneupUploaderBundle into …
eb4ebf7 
…feature/symfony-5
@bytehead
CS fixer
e5454cf
@bytehead
Remove 3.x, add 5.x
41d46ce
@bytehead
WIP PHPStan level 5
92e963d
@bytehead bytehead self-assigned this Feb 14, 2020
@bytehead bytehead added this to the 3.0 milestone Feb 14, 2020
@bytehead bytehead mentioned this pull request Feb 14, 2020
Closed
@ErnadoO
Copy link
Contributor

ErnadoO commented Feb 20, 2020

Hi
image

I think this line should be removed since FilesystemOrphanageStorage constructor have only 4 arguments.

ErnadoO added a commit to ErnadoO/OneupUploaderBundle that referenced this pull request Feb 20, 2020
@ErnadoO
Remove useless argument
289d528 
1up-lab#373 (comment)
@ErnadoO ErnadoO mentioned this pull request Feb 20, 2020
Closed
@bytehead bytehead linked an issue Feb 20, 2020 that may be closed by this pull request
Sf5 ? #364
Closed
@bytehead bytehead changed the title Symfony ^4.4|^5.0 Add support for Symfony 5 and dropped support for Symfony 3 Mar 27, 2020
@bytehead bytehead merged commit 85a777f into master Mar 27, 2020
@bytehead bytehead deleted the feature/symfony-5 branch March 27, 2020 15:45
@bytehead
Copy link
Member Author

Thank you guys for contributing, reviewing and participating in this PR! 🎉

@robertfausk robertfausk mentioned this pull request Mar 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enumag enumag enumag left review comments

@ErnadoO ErnadoO ErnadoO left review comments

Assignees

@bytehead bytehead

Labels
enhancement
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

Sf5 ?
6 participants
@bytehead @ErnadoO @enumag @steveWinter @gubler @patrickbussmann