Remove useless argument #375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should add the argument |
FlysystemOrphanageStorage you mean ? So, why remove this argument from FilesystemOrphanageStorage in this commit ? a mistake ? |
Yes! Hmm, that's obviously a mistake! 🙈 |
bytehead
added a commit
that referenced
this pull request
Feb 20, 2020
|
I've reverted the changes in 8c101c8. Thank you for reporting! |
bytehead
added a commit
that referenced
this pull request
Mar 27, 2020
* Dealing with the modified method signature for UploadedFile which with strict type checking in SF 4.4 fails * SF 4.4 swallows the exception so it never makes it as far as the test * Adding SF 5.0 * Adding SF 5.0 and updating PHP versions to currently supported * Switching config to support SF 5.0's removal of the kernal.root_dir and removal of the templating config variable * Even for non-uploaded files we have to deal with the new File signature otherwise the size ends up as the error * Explicitly set framework.test to true to prevent Travis test failure * Set return type for tearDown method as required by SF 5 * Update to support Twig 3 Replace global functions with namespaced functions * Add Twig requirement due to Twig Extension * Removing SF 3.4 from Travis as discussed * Removed Symfony 3.x stuff * Remove comment * CS fixer * Remove 3.x, add 5.x * WIP PHPStan level 5 * Symfony 4.4 * Adjust version constraints * WIP PHPStan level 6 * Fix issues * Rearranged directory structure * Don't reboot test client every request * Enable PHPStan level 6 * Fix PHPStan * Using event names instead class names (#374) * Fix PHPStan * CS * Use Github actions instead of travis * Add templates * Proper names for tests * Remove tests on windows * Reverts mistakes (see #375, thanks @ErnadoO) * Add configuration for stale bot * Fixes * Remove unused * Return finder instance instead of array * Enable PHPStan level = max * Remove unused * Dispatch also specific events (thanks to @enumag) * PHPUnit 8.5 Co-authored-by: Steve Winter <steve@msdev.co.uk> Co-authored-by: Daryl Gubler <daryl@dev88.co> Co-authored-by: Steve Winter <steveWinter@users.noreply.github.com> Co-authored-by: Patrick Bußmann <patrick.bussmann@bussmann-it.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#373 (comment)